Skip to content

Fix issues identified in formal reviews of all review-sets#56

Merged
Malcolmnixon merged 1 commit intomainfrom
copilot/identify-review-sets-and-fix-issues
Apr 2, 2026
Merged

Fix issues identified in formal reviews of all review-sets#56
Malcolmnixon merged 1 commit intomainfrom
copilot/identify-review-sets-and-fix-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

  • Identify all 18 review-sets in .reviewmark.yaml
  • Run formal code-review sub-agent for all 18 review-sets
  • Fix publishing.yaml: wrong test name for VersionMark-Publish-ConflictReport
  • Fix tool-config.md: replace reference to non-existent FromYamlNode with ValidateTool
  • Fix version-mark-config.md: replace ReadFromFile description with Load method, note ReadFromFile as backward-compat wrapper
  • Fix ContextTests.cs: Assert.Throws → Assert.ThrowsExactly (3 occurrences)

Agent-Logs-Url: https://github.com/demaconsulting/VersionMark/sessions/276b86fd-6d0a-455e-8af6-fa6496f30139

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 2, 2026 19:38
Copilot AI review requested due to automatic review settings April 2, 2026 19:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issues found during formal review across multiple review-sets by aligning requirement/test mappings, updating configuration design docs to match the current loading/linting implementation, and tightening exception assertions in tests.

Changes:

  • Update MSTest assertions to use Assert.ThrowsExactly<ArgumentException> in ContextTests for stricter exception-type validation.
  • Fix ReqStream publishing requirement mapping to reference the correct test for “no matching files” behavior.
  • Update configuration design docs to reflect VersionMarkConfig.Load returning VersionMarkLoadResult (with LintIssues) and ReadFromFile as a backward-compatibility wrapper; update ToolConfig parsing doc to reference ValidateTool.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
test/DemaConsulting.VersionMark.Tests/Cli/ContextTests.cs Tightens exception assertions to require exact ArgumentException type.
docs/reqstream/publishing/publishing.yaml Corrects the referenced test name for the “no matching publish files” requirement.
docs/design/configuration/version-mark-config.md Updates documentation to describe Load/ReadFromFile behavior consistent with current implementation.
docs/design/configuration/tool-config.md Updates YAML parsing documentation to reference VersionMarkConfig.ValidateTool and lint issue behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon merged commit 4048a6a into main Apr 2, 2026
19 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/identify-review-sets-and-fix-issues branch April 2, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants