Fix issues identified in formal reviews of all review-sets#56
Merged
Malcolmnixon merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/demaconsulting/VersionMark/sessions/276b86fd-6d0a-455e-8af6-fa6496f30139 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 2, 2026 17:12
View session
Malcolmnixon
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issues found during formal review across multiple review-sets by aligning requirement/test mappings, updating configuration design docs to match the current loading/linting implementation, and tightening exception assertions in tests.
Changes:
- Update MSTest assertions to use
Assert.ThrowsExactly<ArgumentException>inContextTestsfor stricter exception-type validation. - Fix ReqStream publishing requirement mapping to reference the correct test for “no matching files” behavior.
- Update configuration design docs to reflect
VersionMarkConfig.LoadreturningVersionMarkLoadResult(withLintIssues) andReadFromFileas a backward-compatibility wrapper; update ToolConfig parsing doc to referenceValidateTool.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/DemaConsulting.VersionMark.Tests/Cli/ContextTests.cs | Tightens exception assertions to require exact ArgumentException type. |
| docs/reqstream/publishing/publishing.yaml | Corrects the referenced test name for the “no matching publish files” requirement. |
| docs/design/configuration/version-mark-config.md | Updates documentation to describe Load/ReadFromFile behavior consistent with current implementation. |
| docs/design/configuration/tool-config.md | Updates YAML parsing documentation to reference VersionMarkConfig.ValidateTool and lint issue behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.