Changed default Project Root when build.zig not found#5090
Open
coffeebe4code wants to merge 6 commits intodense-analysis:masterfrom
Open
Changed default Project Root when build.zig not found#5090coffeebe4code wants to merge 6 commits intodense-analysis:masterfrom
coffeebe4code wants to merge 6 commits intodense-analysis:masterfrom
Conversation
Contributor
|
There are linter issues that need fixing: |
w0rp
requested changes
Feb 8, 2026
| return !empty(l:build_rs) ? fnamemodify(l:build_rs, ':h') : '' | ||
| return !empty(l:build_rs) | ||
| \ ? fnamemodify(l:build_rs, ':h') | ||
| \ : expand('#' . a:buffer . ':p:h') |
Member
There was a problem hiding this comment.
The issue with doing this is that ALE will launch an instance of the language server per project root, so you could end up with a lot of duplicate instances being launched. Is there some other project file we can look for to find the root of a Zig project, possibly including the .git directory?
#4993 I'll also mention this idea I pitched. I'll come back to that and finish it eventually in the future if others don't. I would like if if we always used the ale_root` option for setting the root of a project and skipping all filesystem searching so the project root is always configurable, including for the Python project root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zig does not need a project root, but when viewing the std library, there is no build.zig. The current directory is fine for these purposes. zls remains quick on my linux machine.
Addresses this issue