fix expert lsp stdio and register capability#5113
Merged
hsanson merged 2 commits intodense-analysis:masterfrom Apr 10, 2026
Merged
fix expert lsp stdio and register capability#5113hsanson merged 2 commits intodense-analysis:masterfrom
hsanson merged 2 commits intodense-analysis:masterfrom
Conversation
expert requires --stdio to use stdio transport but the linter definition launched it without the flag, so the server never entered lsp mode
some lsp servers like expert send a client/registerCapability request after initialization to dynamically register capabilities, if ale does not respond the server blocks and never processes further messages like textDocument/didOpen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested with expert v0.1.0 installed via homebrew and ale at
ba8b9cba(2026-04-01) installed via vim-plug on macosexpert's lsp server requires
--stdioto use stdio transport (see expert README andexpert --help), but the ale linter definition launched it without the flag so the server never entered lsp modeseparately, expert sends a
client/registerCapabilityrequest after initialization to dynamically register capabilities, and ale had no handler for it, i.e., the server blocked waiting for a response and never processedtextDocument/didOpenor any subsequent messages, making features like go-to-definition non-functionalthe first commit adds
--stdioto the expert launch command, the second adds a handler that acknowledgesclient/registerCapabilityrequests with a null response, matching how ale already handlesworkspace/configurationnote:
client/registerCapabilityis part of the lsp spec and other servers may also use it, so this fix is not expert-specific