Skip to content

ENH: optimize_extended_range should allow using beads and jbcd #64

@derb12

Description

@derb12

Description of the problem/new feature

Since beads and jbcd produce global fits of the baseline whose curvature is controlled by the parameters alpha and beta, respectively, then optimize_extended_range should theoretically work well at selecting the optimal value for them. The plots below show the output baseline and 'rmse' param values using a patched version of optimize_extended_range with beads and jbcd, which demonstrates that this is indeed the case.

Image

This should wait until the optimize_lam branch is merged since optimizers also need a rework on how they filter which algorithms are allowed to be used with them. The filtering should not be based on modules as it currently is, but instead should just look at if the signature of the selected method has required keywords (eg. collab_pls would look for weights, optimize_extended_range would look for poly_order, lam, alpha, beta) with some additional exclusions/special-cases accounted for.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions