Merged
Conversation
New blue looks better in dark mode. logo_plot now also generates the full logo rather than just the curve.
Will be used for examples in both docs and docstrings
Matplotlib's plot directive will now show code by default in order to work with docstring examples. As a result, have to manually hide code when desired in the docs.
Added scipy-doctest as a testing dependency since without it doctests fail because of matplotlib's plotting outputs
Updated the docstrings and added examples for asls, iasls, airpls, and arpls.
Owner
Author
|
Can ignore the failure on the nightly job, that's from my own deprecations that I can address after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
algorithmssection of the docs currently do, rather than just stating their names...Since updating most docstrings is going to be a rather disruptive change, it'd be easier to merge this branch into development now and gradually update each method's docstring alongside other work so that I don't have to go through a merge conflict nightmare later.
Type of Pull Request
Pull Request Checklist