fix HumanName repr for names with single quotes#137
Merged
derek73 merged 1 commit intoderek73:masterfrom Nov 14, 2022
Merged
Conversation
eg `HumanName("O'NEILL")`
Owner
|
For me, the multi line formatting makes it easier to visually inspect. Why would it be better to remove multi line formatting?
|
Contributor
Author
|
it breaks single line logging for me. usually what i saw is that there's a |
Contributor
Author
|
obviously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg
HumanName("O'NEILL")would before this change returnand with the change it will be:
I think it can be further improved by dropping manual multiline formatting etc, let me know if you would accept that as well.