Repository navigation
Fix KiCad 8 library symbol grammar - #323
Merged
Merged
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
giri256
force-pushed
the
fix/kicad8-symbol-grammar
branch
from
July 27, 2026 13:48
3f7676b to
81bbe82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322.
KiCad 8 refuses to open schematics generated by the
kicad8backend because the library symbols contain two forms introduced in KiCad 9. This writespin_numbersusing the syntax KiCad 8 expects and leaves outembedded_fonts, which KiCad 8 does not recognize.I added a regression test against the KiCad 8 writer. The KiCad 9 backend is unchanged.
Tests:
SKIDL_TOOL=KICAD8 pytest tests/unit_tests/ai_tests/test_sexp_schematic.py -q— 32 passed, 4 skippedgit diff --check