Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Added jsconfig.json and example tests fixes to improve Intellisense support #7

Merged
vaidasmaciulis merged 1 commit into from
Apr 27, 2020
Merged

Added jsconfig.json and example tests fixes to improve Intellisense support #7

vaidasmaciulis merged 1 commit into from
Apr 27, 2020

Conversation

@vaidasmaciulis
Copy link
Collaborator

@vaidasmaciulis vaidasmaciulis commented Apr 26, 2020

  1. Jsconfig.json somehow helps VSCode intellisense to catch puppeteer API (i.e. page.)
  2. In example tests, intellisense works for page object classes (i.e. homepage.) when these are declared and initialized in the same line (i.e. let homepage = new HomePage();)

@vaidasmaciulis vaidasmaciulis self-assigned this Apr 27, 2020
@vaidasmaciulis vaidasmaciulis merged commit d4d84af into master Apr 27, 2020
@vaidasmaciulis vaidasmaciulis deleted the add-jsconfig branch January 12, 2021 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dariusnemeiksis dariusnemeiksis dariusnemeiksis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vaidasmaciulis vaidasmaciulis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaidasmaciulis @dariusnemeiksis