This repository was archived by the owner on Feb 3, 2023. It is now read-only.
85 fix environment setup#86
Merged
jevgenijusmarinuskinas merged 2 commits intoplaywrightfrom Jan 14, 2021
Merged
Conversation
Collaborator
jevgenijusmarinuskinas
commented
Jan 4, 2021
jevgenijusmarinuskinas
commented
- Changed environment to PlaywrightEnvironment
- Adapted and fixes Element methods
- Removed duplicate configuration
- Adapted network throttling (for Chromium specifically)
added 2 commits
January 4, 2021 14:07
…nment setup and adapted network throttling (Chromium-only)
jevgenijusmarinuskinas
requested review from
Martynienas,
ernestaszekas and
vaidasmaciulis
| //testEnvironment: "./test-environment/environment.js", | ||
| testEnvironment: "./test-environment/environment.js", | ||
| preset: "jest-playwright-preset", | ||
| testEnvironmentOptions: { |
Collaborator
There was a problem hiding this comment.
where browsers that will run is set, when this is removed?
Collaborator
Author
There was a problem hiding this comment.
jest-playwright.config.js
ernestas-zekas
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.