Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

#85 - Fix webkit tests#94

Merged
ernestas-zekas merged 1 commit intoplaywrightfrom
85-fix-webkit-tests
Feb 5, 2021
Merged

#85 - Fix webkit tests#94
ernestas-zekas merged 1 commit intoplaywrightfrom
85-fix-webkit-tests

Conversation

@ernestas-zekas
Copy link
Collaborator

@ernestas-zekas ernestas-zekas commented Feb 4, 2021 •
edited
Loading

  • Added setting exitOnPageError with value false to avoid crashing tests on webkit;
  • Refactored tests with new demo site as guru99.com is goes down every time all tests and browsers are running at once.
  • Refactored some tests to work on all browsers.

image

Note: Visual regression tests are not counted as they are not fixed yet.

@ernestas-zekas
#85 - Added setting exitOnPageError with value false to avoid crashin…
620be43 
…g tests on webkit;

- Refactored tests with new demo site.
@ernestas-zekas ernestas-zekas merged commit 08b1086 into playwright Feb 5, 2021
@ernestas-zekas ernestas-zekas deleted the 85-fix-webkit-tests branch February 5, 2021 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Martynienas Martynienas Awaiting requested review from Martynienas

2 more reviewers

@vaidasmaciulis vaidasmaciulis vaidasmaciulis approved these changes

@jevgenijusmarinuskinas jevgenijusmarinuskinas jevgenijusmarinuskinas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ernestas-zekas @vaidasmaciulis @jevgenijusmarinuskinas