Skip to content

fix(desktop): remove dead experimental env setters - #321

Merged
dezren39 merged 1 commit into
mainfrom
sweep/115-dead-desktop-env
Oct 23, 2026
Merged

dezren39 merged 1 commit into
mainfrom
sweep/115-dead-desktop-env

Conversation

@dezren39

@dezren39 dezren39 commented Oct 23, 2026 •

Copy link
Copy Markdown

Problem

Fixes #115. The desktop app set OPENCODE_EXPERIMENTAL_ICON_DISCOVERY="true" and OPENCODE_EXPERIMENTAL_FILEWATCHER="true" into its environment on every launch (packages/desktop/src/main/lifecycle/environment.ts), intending to enable icon discovery and the file watcher for the servers it spawns — but nothing in the codebase reads either variable, and the English docs (cli.mdx Experimental table) promised both to users as working enable switches.

  • File watcher: already on by default and governed by different names — packages/cli/src/server-process.ts computes filewatcher: !truthy(process.env.OPENCODE_FILEWATCHER_DISABLE ?? process.env.OPENCODE_DISABLE_FILEWATCHER). Setting OPENCODE_EXPERIMENTAL_FILEWATCHER=true could never change anything.
  • Icon discovery: no such feature exists in v2 under any name (repo-wide search finds no reader and no feature outside the setter itself).

Solution

Direction 2 from the issue (remove the dead setters, align the docs), following the #103 precedent where the docs/setters were aligned with deliberate v2 behaviour:

After this change, no launch-time setter in the desktop lifecycle names a variable nothing reads, and the docs no longer list either variable as a working enable switch — the acceptance criteria of #115. No test is added: the desktop package's testing rules prohibit source-grep/tombstone tests, and there is no behaviour to pin (the removed assignments were unobservable).

Verification

  • git grep for both names across the tree, excluding locale docs: no matches remain (setter and English rows gone).
  • Prettier check passes on both changed files.
  • Desktop package typecheck run locally (see PR checks for CI).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T08:02:50.771448Z 8b10f7b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1401aac3-f7c2-4fe9-9eb1-20fa9e61d52e
📥 Commits

Reviewing files that changed from the base of the PR and between 92158ac and 8b10f7b.

📒 Files selected for processing: 2
  • packages/desktop/src/main/lifecycle/environment.ts
  • packages/web/src/content/docs/cli.mdx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dezren39

Copy link
Copy Markdown
Author

Merging per the standing sweep directive: GitHub Actions is still producing zero runs repo-wide (fresh API check: total_count 0 for this PR's head SHA 8b10f7b), so the only reported check is CodeRabbit (pass) with the PR CLEAN/MERGEABLE. The change itself is verified: four deletions only — the two dead setters in environment.ts (repo-wide grep confirms no reader exists for either variable; the file watcher is governed by OPENCODE_FILEWATCHER_DISABLE/OPENCODE_DISABLE_FILEWATCHER in server-process.ts and is on by default) and the two matching English cli.mdx rows; prettier check passes on both files. If Actions recovers and flags main, it will be fixed in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(desktop): OPENCODE_EXPERIMENTAL_ICON_DISCOVERY / OPENCODE_EXPERIMENTAL_FILEWATCHER are set on every launch but read nowhere

1 participant