fix: combine rephrased and original queries for reranking#12
Open
ividito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some queries get rephrased to a more formal alternative (eg "russia" -> "russian federation") which is less appropriate for trigram similarity scoring. This can lead to correct results falling below the 0.33 threshold for consideration. Using the "russia" example, this allows more localized results like "little russia" or "russian mission, AK" to override the correct results.
This PR will run a search using both iterations of the query, removes duplicate results and combines them both in the reranking agent. This reduces efficiency somewhat, but improves result accuracy.