Conversation
Co-authored-by: Henry Rodman <henry.rodman@gmail.com>
|
@hrodmn this is ready for a review! Please ignore the tons of files in the test fixtures (sorry they clobber the diff quite a bit). |
hrodmn
left a comment
There was a problem hiding this comment.
I think this is great - nice work @jbusecke! The only changes I request are to avoid using assertions for raising errors in the actual runtime code.
For context on the configuration and deployment, the value that we set for TITILER_MULTIDIM_AUTHORIZED_CHUNK_ACCESS will be added as a secret value in a SSM secret that gets shared by multiple applications in a given deploy environment, so we may only have to define it once per deployment environment even if multiple applications want to use the same values.
titiler-multidim/.github/actions/cdk-deploy/action.yml
Lines 50 to 61 in 31c20aa
|
Thanks so much for the review @hrodmn. Ill see if I can get this cleaned up and ready for Monday! |
Replacing #96 since we cannot deploy to sandbox from a fork.
Depends on #95 and developmentseed/titiler#1235
Tasks