Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented May 30, 2025

Description of Changes

Bumps Go version to 1.22 to patch runtime and support upcoming compatibility changes.

Related Issue(s)

resolves devfile/api#1694

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Running Unit Tests

Running Integration Tests

Notes To Reviewer

Any notes you would like to include for the reviewer.

@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk May 30, 2025 16:18
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

openshift/release#65528 is blocking the integration testing from passing.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment for just for my knowledge but looks good to me

Question - I know the issue is to upgrade to 1.22 but should we consider going higher? Since Go supports the last 2 releases I believe we will rapidly run out of support on 1.22, wdyt?

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

Question - I know the issue is to upgrade to 1.22 but should we consider going higher? Since Go supports the last 2 releases I believe we will rapidly run out of support on 1.22, wdyt?

@Jdubrick To my knowledge when I created this issue 1.22 was the highest the latest operator sdk supports, however I do have devfile/api#1696 open as well to bump it to 1.24 as soon as its compatible.

@michael-valdron
Copy link
Member Author

@Jdubrick We could do devfile/api#1696 after devfile/api#1693 is completed to see if 1.24 can still be used with all the upcoming sdk changes.

@michael-valdron michael-valdron requested a review from Jdubrick May 30, 2025 19:34
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after tests pass, if we have issues open for 1.24 then I think all is okay

@openshift-ci
Copy link

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/retest

@michael-valdron michael-valdron merged commit 371776a into devfile:main Jun 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devfile Registry Operator should be updated to support Go 1.22

2 participants