add dockerfile to support offline registry builds#197
add dockerfile to support offline registry builds#197mike-hoang merged 1 commit intodevfile:mainfrom
Conversation
|
Should we flag this PR as DO NOT MERGE, because it expects that first the work of devfile/registry-support#179 has been merged? |
mike-hoang
changed the title
mike-hoang
changed the title
|
Holding this PR until all child tasks are completed from devfile/api#329 as this would be the entry point for creating the offline build with all the new changes to the build scripts |
Signed-off-by: Michael Hoang <mhoang@redhat.com>
|
/retest |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
/lgtm
After devfile/devfile-web#92 is merged we should provide a reference to the devfile registy offline installation guide under the README.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, mike-hoang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Adds a dockerfile that packages resources and updates the devfiles to use the packaged resources.
Which issue(s) this PR fixes:
Link to github issue(s)
devfile/api#329
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: