Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds devcontainer configurations to standardize the development environment for the project. It includes setup for both standard and MEI device development scenarios, along with improved Go debugging capabilities.
Changes:
- Added two devcontainer configurations: one for standard development without MEI device and one for MEI device development on Linux hosts
- Enhanced VS Code launch configurations with dynamic input variables for server address, profile name, and DNS suffix
- Removed
asRootparameter from all Go debug configurations in launch.json
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .vscode/launch.json | Updated Go debug configurations to use input variables and removed deprecated asRoot settings |
| .devcontainer/standard/devcontainer.json | Added standard devcontainer configuration with Go 1.25 and proxy support |
| .devcontainer/pre-create.sh | Added pre-creation script to check/install Intel LMS service on the host |
| .devcontainer/post-create.sh | Added post-creation script for proxy configuration and Go tool installation |
| .devcontainer/mei/devcontainer.json | Added MEI device devcontainer with privileged access and host networking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for doing this @nbmaiti! One suggestion to make this easier to review, it might help to split this into two PRs.
For the |
3dd8444 to
0b7c38a
Compare
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
-> Add devcontainer configuration for development environment setup. Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
0b7c38a to
85b6050
Compare
-> Add devcontainer configuration for development environment setup.
-> Added go debug