Skip to content

[WIP] Make multiple classes and types internal for encapsulation#7

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/hide-implementation-types-again
Closed

[WIP] Make multiple classes and types internal for encapsulation#7
Copilot wants to merge 1 commit intomainfrom
copilot/hide-implementation-types-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>The project exposes a large number of implementation types that should be hidden from consumers</issue_title>
<issue_description>- [ ] Make Jq.Parse internal

  • Change JqFilter to internal abstract class; make CreateNullElementStatic, StructurallyEqual, GetTypeNameStatic, GetValueTextStatic internal
  • Change JqParser to internal sealed class
  • Change JqHaltException to internal sealed class
  • Change JqBreakException to internal sealed class
  • Change JqEnvironment to internal sealed class
  • Change JqPattern, VariablePattern, ArrayPattern, ObjectPattern to internal
  • Change FilterClosure to internal sealed record
  • Change BinaryOp to internal enum
  • Change UserFunctionDef to internal sealed class
  • Change all ~30 filter classes in Filters/ to internal sealed class
  • Update tests that use Jq.Parse to use Jq.Evaluate
  • Build and verify

Back this issue
Back this issue

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI assigned Copilot and kzu Mar 6, 2026
@kzu kzu closed this Mar 6, 2026
Copilot stopped work on behalf of kzu due to an error March 6, 2026 16:15
@kzu kzu deleted the copilot/hide-implementation-types-again branch March 6, 2026 16:16
@devlooped devlooped locked and limited conversation to collaborators Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The project exposes a large number of implementation types that should be hidden from consumers

2 participants