Skip to content

Remove legacy generated.yaml references and unused message template#511

Merged
wurstbrot merged 12 commits intodevsecopsmaturitymodel:mainfrom
HishamHR5:main
Mar 24, 2026
Merged

Remove legacy generated.yaml references and unused message template#511
wurstbrot merged 12 commits intodevsecopsmaturitymodel:mainfrom
HishamHR5:main

Conversation

@HishamHR5
Copy link
Contributor

Changes
-src/assets/YAML/meta.yaml — Removed commented reference to generated/generated.yaml
-src/app/component/modal-message/modal-message.component.ts — Removed generated_yaml error template
-src/app/service/loader/data-loader.service.ts — Removed legacy flag and conditional error suppression

@vbakke vbakke self-requested a review March 17, 2026 21:17
Copy link
Collaborator

@vbakke vbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actual deliberate code to handle backwards compatibility, if anyone has old model files.

However, with the new Settings page, it is now quite easy to get the latest model file, so I vote for removing this code, after all.

Meaning: I approve your merge request, @HishamHR5.

You just have to fix the linting error. :)

@HishamHR5
Copy link
Contributor Author

Hey @vbakke
Fixed linting error

@HishamHR5 HishamHR5 force-pushed the main branch 2 times, most recently from 13a2127 to 9164442 Compare March 23, 2026 11:00
@HishamHR5
Copy link
Contributor Author

@wurstbrot
commits are now GPG signed and verified Could you please merge when you get a chance?
Thank you :)

@wurstbrot wurstbrot merged commit 47283a7 into devsecopsmaturitymodel:main Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants