feat(bulk): add HNSW vector index support to bulk loader#9598
Open
shiva-istari wants to merge 3 commits intomainfrom
Open
feat(bulk): add HNSW vector index support to bulk loader#9598shiva-istari wants to merge 3 commits intomainfrom
shiva-istari wants to merge 3 commits intomainfrom
Conversation
github-actions
bot
added
area/testing
shiva-istari
force-pushed
the
shiva/bulk-vector-index
branch
from
1348296 to
b6c53f0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
shiva-istari
force-pushed
the
shiva/bulk-vector-index
branch
2 times, most recently
from
b4ec39b to
ebf8d1e
Compare
shiva-istari
changed the title
shiva-istari
force-pushed
the
shiva/test-mac-os
branch
from
55a62d6 to
702e740
Compare
shiva-istari
force-pushed
the
shiva/bulk-vector-index
branch
from
ebf8d1e to
90670da
Compare
matthewmcneely
requested changes
Feb 20, 2026
shiva-istari
changed the base branch from
shiva/test-mac-os
to
fix/shiva-test-mac-os
shiva-istari
force-pushed
the
shiva/bulk-vector-index
branch
from
90670da to
52fa0a8
Compare
matthewmcneely
approved these changes
Feb 23, 2026
xqqp
reviewed
Feb 23, 2026
| continue | ||
| } | ||
|
|
||
| fd, err := os.Create(hostFile) |
Contributor
There was a problem hiding this comment.
Consider using defer to close the file descriptor.
xqqp
reviewed
Feb 23, 2026
| tr := tar.NewReader(ts) | ||
| for { | ||
| header, err := tr.Next() | ||
| if err == io.EOF { |
Contributor
There was a problem hiding this comment.
Consider using errors.Is(err, io.EOF) instead. Comparing errors directly is bad practice, because it ignores wrapped errors.
shiva-istari
force-pushed
the
shiva/bulk-vector-index
branch
from
52fa0a8 to
9e4b115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds HNSW vector index support to Dgraph's bulk loader, enabling bulk loading of vector predicates with automatic index construction.
Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.docs repo staged and linked here. This process can
be simplified by going to the public docs site and clicking the
"Edit this page" button at the bottom of page(s) relevant to your changes. Ensure that you
indicate in the PR that this is an unreleased feature so that it does not get merged into
the main docs prematurely.