feat: implement iteration over cache elements#460
Open
ilyatotl wants to merge 2 commits intodgraph-io:mainfrom
Open
feat: implement iteration over cache elements#460ilyatotl wants to merge 2 commits intodgraph-io:mainfrom
ilyatotl wants to merge 2 commits intodgraph-io:mainfrom
Conversation
And paralleling tests
mangalaman93
requested changes
Aug 19, 2025
Contributor
mangalaman93
left a comment
There was a problem hiding this comment.
Thank you for the PR. Do we need to change the API here at all for having iteration function? If not, I'd recommend breaking this PR into two. It would be easy to get one in that does not change the API, and only adds a new API. We can later on review the other one if and when we plan for a major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Often, Ristretto is used not only as a cache before databases, but also as a complete in-memory storage. And there are cases when you need to do something with all the elements in the cache (for example, completely unload them and send them somewhere). However, in the current implementation, this is impossible. For this, the Iter function was implemented, which goes through all the cache elements and calls a callback function for each one of them.
P.S. In addition, when running the tests, it was noticed that they were running for quite a long time, so they were parallelized, which significantly accelerated their work.
Checklist
CHANGELOG.mdfile describing and linking tothis PR