feat: Update hapi version to support Node 16 and drop Node 10#1235
Merged
pgrzesik merged 3 commits intodherault:masterfrom Jul 28, 2021
Merged
feat: Update hapi version to support Node 16 and drop Node 10#1235pgrzesik merged 3 commits intodherault:masterfrom
hapi version to support Node 16 and drop Node 10#1235pgrzesik merged 3 commits intodherault:masterfrom
Conversation
Collaborator
|
Hey @janicduplessis - thanks a lot for the proposal. It looks like the CI tests are failing though, would you be able to look into that? Thanks in advance 🙇 |
Contributor
Author
|
Fixed the tests, looks like hapi now returns 204 status code sometimes (when no body) which I think is fine. |
Contributor
Author
|
@pgrzesik Could you have another look at this? CI is fixed. |
|
Thanks so much for this PR. I just came back to a serverless project after a few months away and was greeted with 20+ deprecation warnings, most of them from HAPI. Would be great to see this PR merged and released! |
pgrzesik
approved these changes
Jul 28, 2021
Collaborator
pgrzesik
left a comment
pgrzesik
left a comment
There was a problem hiding this comment.
Looks great, thank you @janicduplessis - it will be released with a new major version, 8.0.0 due to dropping support for Node v10
pgrzesik
changed the title
hapi version to support Node 16 and drop Node 10
This was referenced Jul 28, 2021
This was referenced Jul 28, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates hapi versions to the latest to fix an issue where requests will hang on node 16. See hapijs/hapi#4225 for the fix in hapi.
However the latest version of hapi isn't compatible with node 10 so this requires dropping support (see https://hapi.dev/resources/changelog/).
Motivation and Context
Support node 16.
Fixes #1229
How Has This Been Tested?
Tested by running a large serverless app with this fix on node 16. Also checked the hapi changelog to make sure no breaking changes would affect this. Added node 16 to CI.
Screenshots (if appropriate):
N/A