Skip to content

Droplets can be created with user_data and private_networking#8

Merged
ivanvanderbyl merged 1 commit into
digitalocean:masterfrom
rbishop:user-data-and-private-networking
Nov 5, 2014
Merged

Droplets can be created with user_data and private_networking#8
ivanvanderbyl merged 1 commit into
digitalocean:masterfrom
rbishop:user-data-and-private-networking

Conversation

@rbishop
Copy link
Copy Markdown
Contributor

@rbishop rbishop commented Oct 31, 2014

  • Add user_data attribute to Droplet resource and mapping
  • Add private_networking attribute to Droplet resource and mapping

I think these features are awesome so I wanted to be able to access them from DropletKit.

Also, there are appears to be some failing tests on master. A lot of tests are expecting a XXXResource but are getting PaginatedResource instead. I didn't have a whole lot of time to investigate unfortunately.

@bobbytables
Copy link
Copy Markdown
Contributor

@rbishop, there's a branch running right now that is going to be for v1.1 and I'd love to see these changes in there. This is the branch: https://github.com/digitalocean/droplet_kit/tree/update-droplet-kit

Maybe we should rebase against that?

@rbishop
Copy link
Copy Markdown
Contributor Author

rbishop commented Oct 31, 2014

@bobbytables Ah, nice. I think I did what you were asking for. Let me know if it's not what you meant.

@bobbytables
Copy link
Copy Markdown
Contributor

Yup! Thank you!

@bobbytables
Copy link
Copy Markdown
Contributor

Hmm, might need another rebase, we can get this in today.

* Add user_data attribute to Droplet resource and mapping
* Add private_networking attribute to Droplet resource and mapping
@rbishop
Copy link
Copy Markdown
Contributor Author

rbishop commented Nov 5, 2014

Hey it looks like the update-droplet-kit branch has been merged into master so I rebased master instead.

@ivanvanderbyl
Copy link
Copy Markdown
Contributor

😁 👍

ivanvanderbyl added a commit that referenced this pull request Nov 5, 2014
Droplets can be created with user_data and private_networking
@ivanvanderbyl ivanvanderbyl merged commit e77cb84 into digitalocean:master Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants