Repository navigation
Keep truncation offset within MD5 digest - #45
Open
JayOfTheKeyboard wants to merge 1 commit into
Open
JayOfTheKeyboard wants to merge 1 commit into
JayOfTheKeyboard wants to merge 1 commit into
Conversation
An MD5 digest is 16 bytes, so a dynamic truncation offset of 13 to 15 read past its end and Evaluate panicked with index out of range. Clamp the offset so 4 bytes are always available. Offsets that worked before give the same codes.
Owner
|
Thank you for pointing out the issue, but I'd rather sunset MD5 entirely. It has never been seen in the wild, nor is it mentioned in any RFC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
An MD5 digest is 16 bytes, so a truncation offset of 13 to 15 read past the end and
Evaluatepanicked with index out of range. This clamps the offset tolen(hashed)-4. Offsets up to 12 give the same codes as before, and SHA1/256/512 are unchanged.TestEvaluateMD5covers offsets 1 and 12 to 15 with HOTP. The expected codes come from Python'shmac, not from this code. Without the fix the test panics.go test,go vetandgo fix -diffare clean.