Skip to content

Message.message_reference.guild_id is a nullable field#1525

Closed
krisppurg wants to merge 4 commits intodiscord:masterfrom
krisppurg:patch-1
Closed

Message.message_reference.guild_id is a nullable field#1525
krisppurg wants to merge 4 commits intodiscord:masterfrom
krisppurg:patch-1

Conversation

@krisppurg
Copy link
Copy Markdown
Contributor

@krisppurg krisppurg commented Apr 19, 2020

No description provided.

@krisppurg krisppurg changed the title guild_id and nonce are not nullable guild_id and nonce are nullable Apr 19, 2020
@krisppurg krisppurg changed the title guild_id and nonce are nullable Message.guild_id and Message.nonce are nullable fields Apr 19, 2020
@krisppurg krisppurg changed the title Message.guild_id and Message.nonce are nullable fields Message.nonce is a nullable field Apr 19, 2020
@FasterSpeeding
Copy link
Copy Markdown
Contributor

FasterSpeeding commented Apr 19, 2020

message.nonce being nullable is unintended behaviour according to @night (see #1447 for source)

@krisppurg
Copy link
Copy Markdown
Contributor Author

krisppurg commented Apr 19, 2020

Oh I see.

@krisppurg krisppurg changed the title Message.nonce is a nullable field Message.message_reference.guild_id is a nullable field Apr 19, 2020
@night
Copy link
Copy Markdown
Member

night commented Apr 20, 2020

guild_id should not be nullable in a message reference context, but it could be undefined. do you have an example where this is true so we can investigate?

@krisppurg
Copy link
Copy Markdown
Contributor Author

krisppurg commented Apr 20, 2020 •
edited
Loading

If you pin a message in a dm channel, you can get message_references.guild_id as null.

@night
Copy link
Copy Markdown
Member

night commented Apr 21, 2020

I see. It looks like we added this into dm contexts then. this will be fixed in next api deploy

@night night closed this Apr 21, 2020
@advaith1
Copy link
Copy Markdown
Contributor

advaith1 commented Apr 21, 2020

Isn't the reference object needed so the auto pin message links to the message that was pinned?

@krisppurg krisppurg deleted the patch-1 branch April 21, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krisppurg @FasterSpeeding @night @advaith1