-
Notifications
You must be signed in to change notification settings - Fork 4
Duplicate include path checks in template resolution #23
Copy link
Copy link
Open
Labels
Description
From PHPStan baseline: src/div.php lines 3289 and 3294.
Both branches call self::fileExists( . '.' . DIV_DEFAULT_TPL_FILE_EXT) and repeat the same condition.
Snippet:
if (self::fileExists( . '.' . DIV_DEFAULT_TPL_FILE_EXT)) { .= '.' . DIV_DEFAULT_TPL_FILE_EXT; } elseif (self::fileExists( . '.' . DIV_DEFAULT_TPL_FILE_EXT)) { .= '.' . DIV_DEFAULT_TPL_FILE_EXT; } ... if ((self::fileExists() || self::fileExists()) && >= ) { ... }
Action: remove duplicate checks and confirm the intended alternative path or extension.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Todo