Merged
Conversation
If no KEM, KDF, or AEAD is enabled, we get compilation errors because an empty enum cannot have #[repr(u16)] applied to it. Additionally, if neither base-mode-open or base-mode-seal is enabled, the library can do no useful work.
jcjones
approved these changes
Nov 24, 2025
jcjones
left a comment
jcjones
left a comment
There was a problem hiding this comment.
There was a lot going on in here, but hey, much simpler now.
Collaborator
Author
|
I'm going to remove the old jobs from the branch protection rule's required checks, and force-push this to get CI passing. |
divergentdave
force-pushed
the
david/package-cleanup
branch
from
d1636fe to
0f4c497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the following cleanups.
divviup-tshas since moved to a different HPKE library, so we don't need this anymore.actions-rsreusable workflows, which are now unmaintained.mod macros;to come first lexically, and add#[macro_use], so we can remove someusehacks.