dkms add does not copy dot-files

[ian-abbott]

My tarball contains a .tarball-version file in the top-level source directory, that is used to set the version number internally. However, dkms's add_source_tree() function uses the command cp -fr "$from"/* "$source_tree/$module-$module_version", which does not match the dot-files in the "$from" directory.

I suggest changing it to cp -fr "$from"/{,.[^.]}* "$source_tree/$module-$module_version". It could also be changed to cp -frT "$from" "$source_tree/$module-$module_version", but POSIX cp does not support the -T option. (GNU coreutils cp and BusyBox cp both support it.)

[ian-abbott]

It would also be nice if the above cp command preserved timestamps.

[scaronni]

Nothing against it, if you can find a solution that works across the board please create a pull request. Thanks.

[ian-abbott]

I realized that the {,.[^.]}* glob will miss double-dot-files, so {,.[^.],..?}* would be better.

[ian-abbott]

I was thinking of adding the -p option to preserve timestamps, but that would also preserve file ownerships and modes. I don't want to assume --preserve=timestamps is available because BusyBox cp doesn't support it. OK, so dkms is normally run as super-user privileges so dkms build can access the files anyway, but should we use the p option and then recursively change the owner:group to 0:0 afterwards?