Skip to content

dkms.in: try to find Gentoo's module signing key and certificate #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scaronni merged 2 commits into from
Mar 1, 2025
Merged

dkms.in: try to find Gentoo's module signing key and certificate #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d309874
dkms.in: try to find Gentoo's module signing key and certificate
Nowa-Ammerlaan Mar 1, 2025
5290692
run_test.sh: add test cases for finding gentoo signing cert/key
Nowa-Ammerlaan Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions dkms.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ setup_kernels_arches()
fi
if [[ ${#arch[@]} -eq 0 ]]; then
case "$running_distribution" in
debian* | ubuntu* | arch*)
debian* | ubuntu* | arch* | gentoo*)
arch[0]=$(uname -m)
;;
*)
Expand Down Expand Up @@ -1100,7 +1100,26 @@ prepare_mok()
SHIM_NOTRIGGER=y update-secureboot-policy --new-key &>/dev/null
update-secureboot-policy --enroll-key
fi
;;
gentoo* )
# If the usual Gentoo/Portage environment variables are set, use those.
mok_signing_key=${MODULES_SIGN_KEY}
mok_certificate=${MODULES_SIGN_CERT}

# If still empty, attempt to read the signing configuration set for portage.
if [[ -z "${mok_signing_key}" && -f /etc/portage/make.conf ]]; then
mok_signing_key=$(grep "^MODULES_SIGN_KEY=" /etc/portage/make.conf | cut -f2 -d= | sed 's/"//g')
fi
if [[ -z "${mok_certificate}" && -f /etc/portage/make.conf ]]; then
mok_certificate=$(grep "^MODULES_SIGN_CERT=" /etc/portage/make.conf | cut -f2 -d= | sed 's/"//g')
fi

if [[ -z "${mok_signing_key}" && -f ${kernel_config} ]]; then
mok_signing_key=$(grep "^CONFIG_MODULE_SIG_KEY=" "${kernel_config}" | cut -f2 -d= | sed 's/"//g')
# Kernel module signing facility requires PEM files containing both
# the key and the certificate, so in this case both will be the same.
mok_certificate=${mok_signing_key}
fi
;;
esac
fi
Expand Down Expand Up @@ -1167,6 +1186,9 @@ prepare_signing()
sign_file="/usr/src/linux-headers-$kernelver/scripts/sign-file"
fi
;;
gentoo* )
sign_file="/usr/src/linux-$kernelver/scripts/sign-file"
;;
esac
if [[ ! -f ${sign_file} ]]; then
sign_file="$install_tree/$kernelver/build/scripts/sign-file"
Expand Down Expand Up @@ -1791,7 +1813,7 @@ do_uninstall()
done

case "$running_distribution" in
debian* | ubuntu* | arch*)
debian* | ubuntu* | arch* | gentoo*)
(if cd "$install_tree/$1"; then rmdir -p --ignore-fail-on-non-empty "${dir_to_remove}"; fi || true)
;;
*)
Expand Down
11 changes: 9 additions & 2 deletions run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ fi
os_id="$(sed -n 's/^ID\s*=\s*\(.*\)$/\1/p' /etc/os-release | tr -d '"')"
shows_errors=yes
distro_sign_file_candidates=
distro_modsigkey=/var/lib/dkms/mok.key
distro_modsigcert=/var/lib/dkms/mok.pub
case "${os_id}" in
centos | fedora | rhel | ovm | almalinux)
expected_dest_loc=extra
Expand Down Expand Up @@ -364,6 +366,11 @@ case "${os_id}" in
gentoo)
expected_dest_loc=kernel/extra
mod_compression_ext=
distro_sign_file_candidates="/usr/src/linux-${KERNEL_VER}/scripts/sign-file"
distro_modsigkey=/root/kernel_key.pem
distro_modsigcert=/root/kernel_cert.pem
echo "MODULES_SIGN_KEY=${distro_modsigkey}" >> /etc/portage/make.conf
echo "MODULES_SIGN_CERT=${distro_modsigcert}" >> /etc/portage/make.conf
;;
*)
echo >&2 "Error: unknown Linux distribution ID ${os_id}"
Expand All @@ -390,8 +397,8 @@ do
done

SIGNING_PROLOGUE_command="Sign command: ${sign_file}"
SIGNING_PROLOGUE_key="Signing key: /var/lib/dkms/mok.key"
SIGNING_PROLOGUE_cert="Public certificate (MOK): /var/lib/dkms/mok.pub"
SIGNING_PROLOGUE_key="Signing key: ${distro_modsigkey}"
SIGNING_PROLOGUE_cert="Public certificate (MOK): ${distro_modsigcert}"
if [ "${sign_file}" = "/usr/bin/kmodsign" ]; then
SIGNING_PROLOGUE_key="Signing key: /var/lib/shim-signed/mok/MOK.priv"
SIGNING_PROLOGUE_cert="Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der"
Expand Down