various fixes #507

anbe42 · 2025-04-01T08:21:05Z

record location of archived original modules and restore them there (record the location when backing up *.ko files replaced by the dkms module for proper restore #480)
support AUTOINSTALL="no" (DKMS 3.1.4 breaks the no-autoinstall behaviour and return no functional parameters during compilation. #491)
do not clean the clean build tree before building the module (is pre_build, clean, build a sane order? #495)
error out on dkms.conf containing duplicate module definitions
common.postinst: run with the same verbosity as autoinstall
internal code refactoring and cleanup
simplify development of new tests
add more tests
add more sanity checks
make some error messages more informative
coding style consistency

this has been a no-op since building is performed in a clean build tree Fixes: dkms-project#495

do not emit the signing prologue if building will be skipped

This is only needed for getting $module and $module_version from dkms.conf while adding the module to $dkms_tree. For subsequent operations these variables are already known from $dkms_tree and having an override config interferes with e.g. querying the state of BUILD_DEPENDS.

error out on missing modules before the copying loop starts

s.t. we don't end up with a partially populated $base_dir in case of errors which fails to satisfy is_module_built() and cannot be cleaned up by unbuild_module()

Fixes: dkms-project#480

to speed up development of new tests

…stall

…mative" this reverts the part of 3397c61 that separates deprecation warnings from status output

deprecation warnings for obsolete dkms.conf directives - are not helpful on removal of (old) modules - add a lot of noise to status output

scaronni · 2025-04-01T08:31:15Z

Awesome, thanks. Will make some tests on RHEL.

scaronni · 2025-04-01T09:37:22Z

Please reference the other tickets you are touching with this pull request.

scaronni · 2025-04-03T08:09:15Z

Awesome, thank you!

vicamo · 2025-08-25T16:38:57Z

@anbe42 may I know the reason why duplicated modules are marked as errors? This breaks Intel ipu6-drivers.

scaronni · 2025-08-25T16:45:12Z

@vicamo what do you mean marked as errors? I've been packaging ipu6-drivers for myself but never hit it: https://github.com/negativo17/dkms-ipu6/blob/master/dkms-ipu6.spec

vicamo · 2025-08-25T17:10:11Z

@vicamo what do you mean marked as errors? I've been packaging ipu6-drivers for myself but never hit it: https://github.com/negativo17/dkms-ipu6/blob/master/dkms-ipu6.spec

Oh, my. I thought this was to disallow duplicated modules to the in-tree ones, but it's really not. Oh, my. I need a cave to hide.

anbe42 added 30 commits March 28, 2025 10:11

dkms: do not clean before building the module

cbf0f33

this has been a no-op since building is performed in a clean build tree Fixes: dkms-project#495

dkms: stay in the build tree

716d119

dkms: reorder prepare_and_actual_build()

719a6dd

dkms: do_build: postpone prepare_kernel_and_signing()

adb8761

do not emit the signing prologue if building will be skipped

dkms: support AUTOINSTALL={yes,no,}

a2b546f

Fixes: dkms-project#491

dkms: $clean has already been defaulted

123a8b7

dkms: report the expected location of the missing module

d7e7eb8

dkms: refer to make.log if pre/post_build scripts failed

5784500

dkms: drop unused variables from dkms_conf_variables

c738b08

dkms: drop unused variable multi_arch

8ee7f4b

dkms: do_build/do_install: error out early without $kernelver or $arch

200e5ce

dkms: setup_kernels_arches: check for empty kernelver or arch entries

b7c4edb

common.postinst: fix ARCH handling

6c72455

common.postinst: show build output

d517104

common.postinst: simplify error handling

6fdd30b

common.postinst: do not use 'cut -d/ -f4' on @moddir@

5b92e6d

dkms: read_conf: provide a global variable 'num_modules'

3ed1ca4

dkms: do_install: run the pre_install script before the big loop

a681bd5

dkms: do_install: error out if cp failed while installing a module

df2e242

dkms: do_install: validate build completeness early

a9a722a

error out on missing modules before the copying loop starts

dkms: do_build: validate build completeness again after the copying loop

60fb09b

dkms: do_build: use a temporary directory to populate $base_dir

a0aedb7

s.t. we don't end up with a partially populated $base_dir in case of errors which fails to satisfy is_module_built() and cannot be cleaned up by unbuild_module()

dkms: remove_module: clean up leftover temporary dirs from do_build

5eea8d2

dkms: do_install: use variables for more paths

1ef3394

dkms: do_install: simplify the actual copying part

cc597cc

dkms: do_uninstall: use variables for some frequently used paths

4be370b

dkms: do_install: record original location while archiving modules

9610a2b

dkms: do_uninstall: restore archived modules to recorded location

814219c

Fixes: dkms-project#480

run_test.sh: support manually running only parts of the testsuite

7c4de7f

to speed up development of new tests

anbe42 added 15 commits March 31, 2025 13:36

run_test.sh: add separators between tests

5f6d63d

test dkms.conf specifying a module twice in BUILT_MODULE_NAME[]

c718fc9

test dkms.conf specifying a module twice in DEST_MODULE_NAME[]

b89c1cd

dkms: introduce read_conf_strict() with extra checks for add/build/in…

b0bc5fb

…stall

dkms: move the zero modules test to read_conf_strict

9763357

prepare testing deprecated directives

b235c86

test deprecated directive REMAKE_INITRD

84e754a

partially revert "Make deprecation warnings less noisy and more infor…

1301a13

…mative" this reverts the part of 3397c61 that separates deprecation warnings from status output

dkms: show dkms.conf deprecation warnings on add/build/install only

716fb29

deprecation warnings for obsolete dkms.conf directives - are not helpful on removal of (old) modules - add a lot of noise to status output

dkms: read_conf_strict: fail on duplicate modules in BUILT_MODULE_NAME[]

4646576

dkms: read_conf_strict: fail on duplicate modules in DEST_MODULE_NAME[]

b3631fc

prefer [[ ]] over [ ] and test

cdc26ab

prefer [[ $var ]] over [[ -n "$var" ]]

20de2b2

prefer [[ ! $var ]] over [[ -z "$var" ]]

26e0829

Makefile: install dkms.service for Debian based distributions, too

076e4d3

anbe42 requested a review from scaronni April 1, 2025 08:21

scaronni self-assigned this Apr 1, 2025

scaronni merged commit b39d806 into dkms-project:main Apr 3, 2025
26 checks passed

scaronni mentioned this pull request Apr 3, 2025

should CLEAN be deprecated? #502

Closed

anbe42 deleted the mixed-fixes branch April 4, 2025 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

various fixes #507

various fixes #507

Uh oh!

anbe42 commented Apr 1, 2025 •

edited

Loading

Uh oh!

scaronni commented Apr 1, 2025

Uh oh!

scaronni commented Apr 1, 2025

Uh oh!

scaronni commented Apr 3, 2025

Uh oh!

Uh oh!

vicamo commented Aug 25, 2025

Uh oh!

scaronni commented Aug 25, 2025

Uh oh!

vicamo commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

various fixes #507

various fixes #507

Uh oh!

Conversation

anbe42 commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scaronni commented Apr 1, 2025

Uh oh!

scaronni commented Apr 1, 2025

Uh oh!

scaronni commented Apr 3, 2025

Uh oh!

Uh oh!

vicamo commented Aug 25, 2025

Uh oh!

scaronni commented Aug 25, 2025

Uh oh!

vicamo commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anbe42 commented Apr 1, 2025 •

edited

Loading