fix dkms getting stuck with an incomplete $m/$v/$k/$a/module/ directory #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_module_built currently calls set_module_suffix and read_conf which sets lots of variables as a side effect. Explicitly call these from the respective do_whatever functions where they are needed.
…odule/ tree 'dkms remove --all' cannot clean that up (the module is not considered built for $k/$a), leaving it in added state and causing a subsequent 'dkms add' or 'dkms build' to fail
do not check the content of the directory for completeness on normal usage to allow e.g. removal of incomplete ones do_build tries hard not to create incomplete $m/$v/$k/$a/module/ trees do_install checks for completeness before starting to copy files module_status_built_extra checks for missing modules, too
Member
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous changes (using a tempdir in do_build) should have reduced the likelyhood that dkms gets stuck with an incomplete $m/$v/$k/$a/module/ directory.
But it didn't solve the case if dkms is already in such a state.
is_module_builtwould return false andremove_moduletherefore does nothing, whiledo_buildwill refuse to do anything because the directory already exists.Relax the check in
is_module_built(there will be more thorough checks for completeness indo_install) to allowremove_moduleto clean up the mess.