Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation#54
Sprint 4: Basket Page, Catalog Page Enhancements, and About Us Page Implementation#54
Conversation
Implement the About Us Page
…rce-Application into release/basket-about_us
| <Flex vertical align="center" gap={20} style={{ padding: 20 }}> | ||
| <Title>About Us</Title> | ||
| <AboutUsCard | ||
| photo={artyomPhoto} |
There was a problem hiding this comment.
Данные про каждого человека лучше вынести в отдельную константу - так будет легче редактировать их при необходимости + сократится код компонента
| githubLink="https://github.com/dmalashev" | ||
| /> | ||
| <Title level={4}> | ||
| To provide joint work in the team and separate tasks we used Jira dashboard. We decomposited tasks to clearly |
There was a problem hiding this comment.
Было бы классно добавить стек технологий и список инструментов, которые использовали в проекте
| ?.find((attribute) => attribute.name === 'release_year') | ||
| ?.value.split('-')[0] || 'No Year'; | ||
|
|
||
| const label: string = |
There was a problem hiding this comment.
Код аналогичный для 3 характеристик - можно вынести в отдельную функцию
| const discount: number | undefined = productObject?.masterVariant.prices?.find((price) => price?.country === 'US') | ||
| ?.discounted?.value.centAmount; | ||
|
|
||
| const items: DescriptionsProps['items'] = [ |
There was a problem hiding this comment.
Константу можно вынести в отдельный файл
|
|
||
| return ( | ||
| <div className="main"> | ||
| <Typography.Title level={1} style={{ borderRadius: '5px', color: 'white', textAlign: 'center' }}> |
There was a problem hiding this comment.
См. как используется деструктуризация для Typography в других компонентах
There was a problem hiding this comment.
Да, мне я просто так быстро писал, что решил сэкономить 2-3 секунды, не делаю деструктуризацию)
There was a problem hiding this comment.
Опечатка в названии файла
| import './cart-titles.css'; | ||
|
|
||
| const { Text } = Typography; | ||
| const getSpan = (index: number) => { |
There was a problem hiding this comment.
Какие-то магические числа - лучше заменить на более понятные
| color: #DB4444; | ||
| } | ||
|
|
||
| @media (width <= 580px) { |
There was a problem hiding this comment.
Можно не дублировать медиа-запрос
4 participants
Task: link
Screenshot:
Deploy: link
Done 17.06.2025/ deadline 17.06.2025
Mentions: @katie-soft @baranovdv
Brief description:
Score: 0 / 60
Mentor Evaluation Criteria (0 / 60 points): 👨🏫
Penalties for Mentor Evaluation Criteria: ❌
Linter Errors (0 / 5 points): If there are errors from the linter, a penalty of 5 points will be applied. Ensure that you follow the linter rules to maintain high code quality. 🛠️📝🛑
Prettier Errors (0 / 5 points): If there are formatting errors detected by Prettier, a penalty of 5 points will be applied. It's important to adhere to established formatting conventions for clean, readable code. 📐✍️🛑
Presence of 'any' (0 / 5 points): The use of 'any' in TypeScript can lead to potential typing issues and is generally discouraged. A penalty of 5 points will be applied if 'any' is found in the code. 🚫🔍🛑
Non-functional Scripts in package.json (0 / 5 points): All scripts defined in the package.json should function correctly. If there are non-working scripts, a penalty of 5 points will be applied. ⚙️📦🛑
Non-SPA Application (0 / 60 points): The application should be a Single Page Application (SPA) with an empty index.html. If this requirement is not met, a penalty of 60 points will be applied.⚠️ 🖥️🛑