Skip to content

Add option to matcher to ignore authorization header#103

Merged
dnaeon merged 2 commits into
dnaeon:v4from
seatgeek:zh-matcher-ignore-auth-option
Sep 10, 2024
Merged

Add option to matcher to ignore authorization header#103
dnaeon merged 2 commits into
dnaeon:v4from
seatgeek:zh-matcher-ignore-auth-option

Conversation

@zhammer

@zhammer zhammer commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

The suggestion in the readme to clear authorization headers in hooks isn't working for us; when we attempt to run against the recorded cassettes the match fails as the http.Request has an Authorization header that the cassette interaction doesn't.

@codecov-commenter

codecov-commenter commented Sep 10, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.40%. Comparing base (1ae1a38) to head (23299c2).
⚠️ Report is 32 commits behind head on v4.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               v4     #103      +/-   ##
==========================================
+ Coverage   51.61%   52.40%   +0.79%     
==========================================
  Files           4        4              
  Lines         494      498       +4     
==========================================
+ Hits          255      261       +6     
+ Misses        218      217       -1     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dnaeon dnaeon merged commit d91ca23 into dnaeon:v4 Sep 10, 2024
@dnaeon

dnaeon commented Sep 10, 2024

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants