No longer require contact_id to purchase LetsEncrypt certificates#314
Merged
Conversation
jacegu
force-pushed
the
change/certificate-contact-id
branch
from
bbcca57 to
44904ad
Compare
jacegu
requested review from
a team,
AGS4NO and
DXTimer
and removed request for
a team
DXTimer
reviewed
May 23, 2022
DXTimer
approved these changes
May 23, 2022
DXTimer
left a comment
DXTimer
left a comment
Contributor
There was a problem hiding this comment.
Copy suggestion added, but this change looks good.
Co-authored-by: Ivan Bakalov <ibbakalov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer require a contact_id to be provided to be able to purchase a Lets Encrypt certificate.
This one is a little trickier than other clients because of the the way we build the attributes to be used to purchase a LetsEncrypt certificate in
LetsencryptCertificateInput. I have added a deprecation warning, while trying not to introduce any breaking changes.