Use bashbrew to gather the canonical list of supported suites#164
Use bashbrew to gather the canonical list of supported suites#164tianon merged 1 commit intodocker-library:masterfrom
bashbrew to gather the canonical list of supported suites#164Conversation
| | | ||
| latest | .*stable | devel | rolling | testing # stable/development/rolling aliases | ||
| | | ||
| .* - .* # anything with a hyphen |
There was a problem hiding this comment.
I know the "x" option causes the regular expression engine to ignore whitespace, but is there a reason to not just have .*-.* or even just - here?
There was a problem hiding this comment.
I thought .*-.* looked a little compressed and this helped it be more obvious, personally, but I don't feel strongly about it (especially with the comment out to the side which makes it pretty obvious 😂) -- we can't do just - because of the :+$ anchoring outside the parenthesis here (we're matching the full "tag" portion of the image references explicitly with this).
| ' | ||
| )" | ||
| # TODO expand this and do our supported architectures detection here too, while we've already done the lookups? Ubuntu version number lookups via this method too? (unfortunately we can't map Debian codenames to aliases like "stable" this way) | ||
| eval "distsSuites=( $dists )" |
There was a problem hiding this comment.
Is this safer than mapfile/readarray?
There was a problem hiding this comment.
It's more reliable in my experience (and certainly no less safe).
Changes: - docker-library/buildpack-deps@ab3ae04: Add Ubuntu Plucky (25.04) - docker-library/buildpack-deps@4f4a759: Merge pull request docker-library/buildpack-deps#164 from infosiftr/canonical-suites - docker-library/buildpack-deps@49631df: Simplify and update `verify-templating.yml` - docker-library/buildpack-deps@ad037d4: Update README - docker-library/buildpack-deps@92d8c61: Merge pull request docker-library/buildpack-deps#165 from infosiftr/jq-IN - docker-library/buildpack-deps@c708f4c: Use jq's `IN()` instead of `index()` - docker-library/buildpack-deps@cc2dc88: Update `generate-stackbrew-library.sh` to support `BASHBREW_LIBRARY` for easier cascading updates
3 participants
This is an attempt to help codify #162, and make sure that it's correct / mostly automated. I'd love to figure out a clean way to help @docker-library-bot be able to make these kinds of updates automatically, but that's a much larger/more complicated problem.
I'm not 100% sold on it, especially how fiddly and frankly unapproachable my filtering method is.