note about usage of summary feature with download-artifact action#1337
Merged
crazy-max merged 1 commit intodocker:masterfrom Mar 10, 2025
Merged
note about usage of summary feature with download-artifact action#1337crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
73f620d to
6b5ebd8
Compare
thompson-shaun
approved these changes
Mar 7, 2025
tonistiigi
reviewed
Mar 7, 2025
README.md
Outdated
| > | ||
| > If you're using the [`actions/download-artifact`](https://github.com/actions/download-artifact) | ||
| > action in your workflow, you need to ignore the build record artifacts | ||
| > if you don't specify the `name` input (download all artifacts), otherwise the |
Member
There was a problem hiding this comment.
What is "name" input? You mean "pattern" ?
Member
Author
There was a problem hiding this comment.
No I really mean name: https://github.com/actions/download-artifact/blob/cc203385981b70ca67e1cc392babf9cc229d5806/action.yml#L5-L7
Maybe I can just remove this part if that's confusing
Member
There was a problem hiding this comment.
Ah, it is confusing because the example is using pattern. If we want to be very clear, I think we should provide examples for both name and pattern.
Member
Author
There was a problem hiding this comment.
Updated to explain that this applies only if name and pattern are not set.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6b5ebd8 to
9bea05f
Compare
tonistiigi
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to