update github.com/spf13/cobra v1.10.2, switch to go.yaml.in/yaml/v3#71
Merged
thaJeztah merged 1 commit intodocker:mainfrom Dec 9, 2025
Merged
update github.com/spf13/cobra v1.10.2, switch to go.yaml.in/yaml/v3#71thaJeztah merged 1 commit intodocker:mainfrom
thaJeztah merged 1 commit intodocker:mainfrom
Conversation
Only remaining use is in testifiy, which has a pending PR to switch Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
218bb03 to
f73782d
Compare
1 task
There was a problem hiding this comment.
Pull request overview
This PR attempts to update dependencies including upgrading github.com/spf13/cobra from v1.8.1 to v1.10.2 and switching the YAML library import path. However, there is a critical issue: the PR incorrectly uses go.yaml.in/yaml/v3 as the module path instead of the correct gopkg.in/yaml.v3.
Key Changes:
- Updates
github.com/spf13/cobrafrom v1.8.1 to v1.10.2 - Updates
github.com/spf13/pflagfrom v1.0.5 to v1.0.10 - Incorrectly attempts to switch from
gopkg.in/yaml.v3togo.yaml.in/yaml/v3(this is an invalid module path)
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates cobra and pflag versions; incorrectly adds go.yaml.in/yaml/v3 instead of gopkg.in/yaml.v3 |
| go.sum | Adds checksums for updated dependencies including the incorrect go.yaml.in/yaml/v3 module |
| clidocstool_yaml.go | Updates import to use incorrect go.yaml.in/yaml/v3 path |
| example/go.mod | Reflects dependency updates with incorrect yaml module path |
| example/go.sum | Adds checksums for updated dependencies including incorrect yaml module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vvoland
approved these changes
Dec 9, 2025
Member
Author
|
Thx! I'll have a look at updating some other dependencies in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only remaining use is in testifiy, which has a pending PR to switch