config: remove docs.docker.com as site URL#10477
Merged
usha-mandya merged 1 commit intodocker:masterfrom Mar 20, 2020
Merged
Conversation
Having this variable set causes redirects to always redirect to https://docs.docker.com, which makes it not possible to preview redirects locally, or to host them on a different domain (e.g. on a staging domain). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@StefanScherer @usha-mandya PTAL; please double-check if this has no side-effects. I couldn't find any, but perhaps may have missed some |
Member
|
Can't think of any issues arising due to this change. @StefanScherer Any thoughts? |
Member
|
Looking forward to test this in docs-test website. |
Member
|
Yes, the non existing page https://docs-test.docker.com/v17.03/engine/admin/volumes/ is now redirected to https://docs-test.docker.com/storage/ 🎉 |
Member
|
Thanks Stefan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracting this from #10471
Having this variable set causes redirects to always redirect to https://docs.docker.com, which makes it not possible to preview redirects locally, or to host them on a different domain (e.g. on a staging domain).