Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
crazy-max
added
the
status/do-not-merge
github-actions
bot
added
area/cli
crazy-max
force-pushed
the
model-cli
branch
3 times, most recently
from
ed76536 to
6378aeb
Compare
crazy-max
requested review from
ArthurFlag,
sarahsanders-docker and
thaJeztah
as code owners
crazy-max
removed
the
status/do-not-merge
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
Rebased to fix conflict after #22687 was merged |
|
vale seems to fail: https://github.com/docker/docs/actions/runs/15295918829/job/43024912108?pr=22681
But don't know why if someone wants to take a look. |
|
@crazy-max we're good now 🚀 |
|
|
||
|
|
||
| <!---MARKER_GEN_END--> | ||
|
|
There was a problem hiding this comment.
Why this change? This is vendored and should not be edited manually 🤔
There was a problem hiding this comment.
Auto-save in my editor trimmed stuff when I was testing the vale fix... Should I revert this? (do we care since it's autogen?)
There was a problem hiding this comment.
(do we care since it's autogen?)
If you mean autogen on ci that's not the case, it's only done through make vendor or hugo mod vendor so should not be edited whatsoever. But I see there is nothing atm to validate that vendor dir is pristine. We should look at this.
There was a problem hiding this comment.
Good point, i will create a ticket. I also reverted the formatting.
## Description Adds model-cli reference docs. ## Related issues or tickets * docker/model-cli#62 * docker/model-cli#69 ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> Co-authored-by: ArthurFlag <arthur.flageul@docker.com>
2 participants
Description
Adds model-cli reference docs.
Related issues or tickets
Reviews