Use hostname-based routing instead of ports for different services#156
Open
Use hostname-based routing instead of ports for different services#156
Conversation
- Add Traefik to the stack to support hostname-based routing on 3030 - Move VS Code to be available at vscode.localhost - In development, set marlin.localhost to go to marlin mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why?
This PR is intended to make the user experience a little bit easier, especially in development when there are quite a few different services all exposed on different ports. This also eliminates one step in the case we want to run a labspace in another environment where we want different names/URLs for each of the services.
Notably, this PR is continuing the use of port 3030, since it's well documented in various labspace readmes, the extension, etc. And since it isn't a reserved port, all good!