Merged
Conversation
Fix typo in `dbal.connections.default_dbname` configuration
Using with() on a stub is deprecated. We don't want to check that we call this object with 'doctrine', we just want to only return $mockDoctrine when it is called with 'doctrine' and nothing else.
Not having a version constraint for this package causes deprecations because it expects the framework bundle to define its extension by extending a non deprecated class, and that is not the case with v7 of that bundle.
Address deprecations
greg0ire
commented
Feb 11, 2026
| static function (ContainerBuilder $containerBuilder) use ($driverNamespace): void { | ||
| $containerBuilder->addCompilerPass(DoctrineOrmMappingsPass::createAttributeMappingDriver( | ||
| [$driverNamespace], | ||
| /** @phpstan-ignore argument.type */ |
Member
Author
There was a problem hiding this comment.
In the line below, realpath returns false. To be clarified by @bobvandevijver
Member
Author
There was a problem hiding this comment.
I ended up using dummy/path, since apparently it does not matter 🤷
Contributor
There was a problem hiding this comment.
Yeah, the path doesn't matter, but the argument is required to supply. If I recall correctly I grabbed the realpath one from another test that uses the createXmlBundleTestContainer method, but using dummy/path should be fine. The test is about the driver being registered correctly, which is validated before the path is used anyways.
greg0ire
commented
Feb 11, 2026
tests/DependencyInjection/Compiler/DoctrineOrmMappingsPassTest.php
Outdated
Show resolved
Hide resolved
Member
Author
|
Regarding the remaining failure, see #2198 (comment) |
greg0ire
requested review from
GromNaN,
SenseException,
derrabus,
dmaicher,
ostrolucky and
stof
greg0ire
force-pushed
the
3.2.x
branch
2 times, most recently
from
4c29b97 to
9a2b3d4
Compare
GromNaN
approved these changes
Feb 12, 2026
ostrolucky
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.