Skip to content

Comments

Fix package validation#2926

Merged
martincostello merged 3 commits intomasterfrom
fix-package-validation
Jun 21, 2024
Merged

Fix package validation#2926
martincostello merged 3 commits intomasterfrom
fix-package-validation

Conversation

@martincostello
Copy link
Collaborator

Fix the package validation job not failing if there are any issues.

Fix the package validation job not failing if there are any issues.
@martincostello martincostello added github_actions Pull requests that update GitHub Actions code bug fix labels May 29, 2024
@martincostello martincostello added this to the v6.7.0 milestone May 29, 2024
@martincostello martincostello enabled auto-merge (rebase) May 29, 2024 12:47
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (ace3015) to head (05f1d1c).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
- Coverage   90.10%   87.86%   -2.24%     
==========================================
  Files          72       93      +21     
  Lines        2728     3132     +404     
  Branches      431      540     +109     
==========================================
+ Hits         2458     2752     +294     
- Misses        270      380     +110     
Flag Coverage Δ
Linux 87.78% <ø> (-2.33%) ⬇️
Windows 80.45% <ø> (-9.66%) ⬇️
macOS 90.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Use `exit` not `return` to get the correct behaviour.
Add a tools manifest to allow dependabot to update to future versions of dotnet-validate.
Copy link
Collaborator

@mesMess mesMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action changes to support version checks and proper validation.

@martincostello martincostello merged commit 5303636 into master Jun 21, 2024
@martincostello martincostello deleted the fix-package-validation branch June 21, 2024 04:55
This was referenced Aug 1, 2025
This was referenced Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants