Avoid exception checking nullability#3119
Merged
martincostello merged 1 commit intodomaindrivendev:masterfrom Nov 23, 2024
Merged
Avoid exception checking nullability#3119martincostello merged 1 commit intodomaindrivendev:masterfrom
martincostello merged 1 commit intodomaindrivendev:masterfrom
Conversation
- Do not throw if we cannot determine the nullability of a dictionary. - Clean-up some code analysis suggestions. Resolves domaindrivendev#3070. Resolves domaindrivendev#2793.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3119 +/- ##
==========================================
- Coverage 91.43% 89.44% -2.00%
==========================================
Files 76 97 +21
Lines 3119 3523 +404
Branches 519 627 +108
==========================================
+ Hits 2852 3151 +299
- Misses 267 372 +105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dldldlepl
approved these changes
Nov 20, 2024
mesMess
approved these changes
Nov 23, 2024
Collaborator
mesMess
left a comment
mesMess
left a comment
There was a problem hiding this comment.
Code cleanup
Changing to concrete types (in-code) over var 👍🏼
Nullability exception check fix
This was referenced Jul 31, 2025
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
timerknight/skills-secure-repository-supply-chain#17
Open
Open
This was referenced Feb 16, 2026
Closed
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.1.3
EltonCoura/skills-secure-repository-supply-chain#23
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3070.
Resolves #2793 (as it's the last linked issue).