Open
Conversation
p4pper
suggested changes
Dec 6, 2024
p4pper
left a comment
p4pper
left a comment
There was a problem hiding this comment.
It's useful to include information about ROM generation, though, I'm not entirely sure I agree with the recommendation to use Apple ROMs derived from GenSMBIOS, but it shouldn't actually matter.
I propose rewording the section, it's better to make the mac address from your wifi/ethernet card, which is really simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenSMBIOS will generate an Apple ROM that is okay to use