Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds deconstruction support for KeyValuePair<TKey, TValue> to enable tuple-like destructuring syntax. This allows developers to use var (key, value) = kvp; syntax with KeyValuePair objects.
Key changes:
- Adds a
Deconstructextension method forKeyValuePair<TKey, TValue> - Includes conditional compilation to only provide this for frameworks that don't already have it
- Uses a
notnullconstraint on theTKeytype parameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/DotNetCampus.LatestCSharpFeatures/KeyValuePair/KeyValuePair.g.cs
Outdated
Show resolved
Hide resolved
src/DotNetCampus.LatestCSharpFeatures/KeyValuePair/KeyValuePair.g.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lindexi
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.