Skip to content

Move to shared -SqlInternalTransaction#1346

Merged
Kaur-Parminder merged 13 commits into
dotnet:mainfrom
Kaur-Parminder:CodeMergeSqlInternalTransaction
Mar 9, 2022
Merged

Move to shared -SqlInternalTransaction#1346
Kaur-Parminder merged 13 commits into
dotnet:mainfrom
Kaur-Parminder:CodeMergeSqlInternalTransaction

Conversation

@Kaur-Parminder

Copy link
Copy Markdown
Contributor

This is part of #1261 . Move the code to common folder.

@Kaur-Parminder Kaur-Parminder added the Code Health 💊 Issues/PRs that are targeted to source code quality improvements. label Oct 13, 2021
@Kaur-Parminder Kaur-Parminder added this to the 4.0.0-preview3 milestone Oct 13, 2021

@DavoudEshtehari DavoudEshtehari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The _transactionType can be readonly.
  • Naming violation : private static int _objectTypeCount; // EventSource counter

Comment thread src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Outdated
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Outdated
@cheenamalhotra cheenamalhotra removed this from the 4.0.0-preview3 milestone Oct 16, 2021
Comment thread src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Outdated
Comment thread src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Outdated
@JRahnama JRahnama added this to the 5.0.0-preview1 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Health 💊 Issues/PRs that are targeted to source code quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants