Skip to content

Fix | Addressing the excepted behavior when error class is greater than 20 on retry connecting#1953

Merged
JRahnama merged 5 commits into
dotnet:mainfrom
JRahnama:Issue-1874
Apr 3, 2023
Merged

Fix | Addressing the excepted behavior when error class is greater than 20 on retry connecting#1953
JRahnama merged 5 commits into
dotnet:mainfrom
JRahnama:Issue-1874

Conversation

@JRahnama

Copy link
Copy Markdown
Contributor

Fixes issue #1874

@JRahnama JRahnama changed the title Fix | Addressing the excepted behavior when error class is greater than 20 Fix | Addressing the excepted behavior when error class is greater than 20 on retry connecting Mar 14, 2023
@lcheunglci lcheunglci added this to the 5.2.0-preview1 milestone Mar 21, 2023
@lcheunglci

Copy link
Copy Markdown
Contributor

/azurepipelines run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@codecov

codecov Bot commented Mar 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.06 ⚠️

Comparison is base (73c6b2f) 71.53% compared to head (594dbeb) 70.47%.

❗ Current head 594dbeb differs from pull request most recent head 3f066d9. Consider uploading reports for the commit 3f066d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   71.53%   70.47%   -1.06%     
==========================================
  Files         306      306              
  Lines       61841    61569     -272     
==========================================
- Hits        44235    43390     -845     
- Misses      17606    18179     +573     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.26% <100.00%> (-2.44%) ⬇️
netfx 69.09% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Microsoft/Data/SqlClient/SqlConnection.cs 78.93% <100.00%> (+0.19%) ⬆️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs 59.43% <100.00%> (+0.54%) ⬆️

... and 51 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants