Code Health | Cleanup SNIMARSConnection#1985
Merged
JRahnama merged 4 commits intodotnet:mainfrom May 3, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 70.59% 70.95% +0.36%
==========================================
Files 306 306
Lines 61667 64036 +2369
==========================================
+ Hits 43533 45437 +1904
- Misses 18134 18599 +465
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
test failure is the usual unreliable reliability test and 3 legs failed to configure their firewall. |
Contributor
|
/azurepiplines run |
David-Engel
approved these changes
Apr 19, 2023
JRahnama
approved these changes
May 3, 2023
JRahnama
changed the title
SNIMARSConnectionSNIMARSConnection
DavoudEshtehari
added
Code Health 💊
kant2002
pushed a commit
to kant2002/SqlClient
that referenced
this pull request
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #933 many changes were made to SNIMarsConnection which were then lost when that PR was reverted. This PR implements the harmless and side-effect-less changes such as using scoped event tracing like the rest of SNI does, cleaning up a class name variable and adding a dedicated sync object (there are no locks on instances of this class outside this file, i've checked).
This does not change the demuxing code in any way. I want to get the files cleaned up and then try again with the muxing code in a future PR. this is a simple way to get easy changes in place minimizing review complexity.