Fix th-TH culture info issue on Managed SNI#2066
Merged
DavoudEshtehari merged 14 commits intodotnet:mainfrom Jun 28, 2023
Merged
Fix th-TH culture info issue on Managed SNI#2066DavoudEshtehari merged 14 commits intodotnet:mainfrom
DavoudEshtehari merged 14 commits intodotnet:mainfrom
Conversation
…t string Encrypt option into SqlConnectionEncryptionOption type.
…o convert string Encrypt option into SqlConnectionEncryptionOption type." This reverts commit 5c505a1.
arellegue
requested review from
David-Engel,
DavoudEshtehari,
JRahnama and
Kaur-Parminder
Wraith2
reviewed
Jun 16, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Jun 16, 2023
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
==========================================
- Coverage 70.80% 70.22% -0.58%
==========================================
Files 305 305
Lines 61819 61819
==========================================
- Hits 43770 43413 -357
- Misses 18049 18406 +357
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
DavoudEshtehari
changed the title
DavoudEshtehari
added
the
Area\Managed SNI
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
Add isUsingManagedSNI annotation to unit test.
Replaced [ConditionalFact] with just [Fact]
Added catch { throw; } back.
DavoudEshtehari
approved these changes
Jun 21, 2023
JRahnama
approved these changes
Jun 22, 2023
roji
reviewed
Jun 22, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
JRahnama
reviewed
Jun 22, 2023
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1579