Merge TDSParserStateObject.StateSnapshot#2122
Merged
David-Engel merged 2 commits intodotnet:mainfrom Aug 16, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 69.98% 70.95% +0.96%
==========================================
Files 306 306
Lines 62051 61812 -239
==========================================
+ Hits 43428 43857 +429
+ Misses 18623 17955 -668
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
David-Engel
approved these changes
Aug 14, 2023
Contributor
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
Pretty straightforward changes. Thanks!
cheenamalhotra
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to merging netfx and netcore codebases. I need this particular set of classes synchronized for async string perf work.
I've renamed the TdsParserStateObjects because when you have files with the name name (different paths) visual studio doesn't work very well with them. In netfx i could see both but couldn't navigate to items in them properly. In netcore only one file was visible so you couldn't get to shared parts at all. It's now clearer both in the vs ui and in PR's where we work by filename.
I've taken elements which are identical in both netfx and netcore and moved them to the shared partial class. The other elements that are not currently shared will be updated in other PR's
@David-Engel once the current release is done could this get a quick review so i can get some momentum on this merging. I can keep working on relatively small and hopefully easy to review PR's bringing netfx in sync with netcore piece by piece if you can keep the review side moving.