Remove empty statement#2136
Merged
JRahnama merged 1 commit intodotnet:mainfrom Aug 23, 2023
JRahnama:remove-empty-statement
Merged
Remove empty statement#2136JRahnama merged 1 commit intodotnet:mainfrom JRahnama:remove-empty-statement
JRahnama merged 1 commit intodotnet:mainfrom
JRahnama:remove-empty-statement
Conversation
Closed
David-Engel
approved these changes
Aug 22, 2023
arellegue
approved these changes
Aug 22, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 70.98% 70.97% -0.02%
==========================================
Files 305 305
Lines 61818 61844 +26
==========================================
+ Hits 43884 43891 +7
- Misses 17934 17953 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Wraith2
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2133.
Empty statements are valid in C# and have some use-cases. This, however seemed oversighted, but had no effect on perf or caused any issue at compile time. For code-cleanup purposes I have addressed it in this PR.